[FFmpeg-devel] [PATCH] Deprecate oldabi branch by adding a warning to configure

[Michael Niedermayer]

On Thu, Jul 11, 2013 at 07:48:31PM -0700, Timothy Gu wrote:
> On Jul 11, 2013 7:03 PM, "Michael Niedermayer" <michaelni at gmx.at> wrote:
> >
> > On Thu, Jul 11, 2013 at 06:02:24PM -0700, Timothy Gu wrote:
> > > In order to build, users must now explicitly pass --enable-building to
> > > configure.
> > > ---
> > >  configure | 20 ++++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > >
> > > diff --git a/configure b/configure
> > > index 25cea23..7f8df8a 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -72,6 +72,9 @@ Standard options:
> > >    --mandir=DIR             install man page in DIR [PREFIX/share/man]
> > >
> > >  Configuration options:
> > > +  --enable-building        enable building ONLY if you understand the
> > > +                           potential security risk posed by using this
> > > +                           branch (oldabi)
> > >    --disable-static         do not build static libraries [no]
> > >    --enable-shared          build shared libraries [no]
> > >    --enable-gpl             allow use of GPL code, the resulting libs
> > > @@ -910,6 +913,7 @@ CONFIG_LIST="
> > >      avfilter
> > >      avformat
> > >      avisynth
> > > +    building
> > >      bzlib
> > >      crystalhd
> > >      dct
> > > @@ -1936,6 +1940,22 @@ filter_cflags=echo
> > >  filter_cppflags=echo
> > >  filter_asflags=echo
> > >
> > > +if ! enabled building; then
> > > +    cat <<EOF
> > > +!!!! WARNING !!!!
> > > +
> > > +This branch is NOT actively maintained and CAN contain serious security
> > > +issues. This branch is only provided for historical interest.
> > > +
> >
> > > +For a maintained branch with the old API/ABI, please use release/0.5 or
> > > +release/0.7.
> >
> > i dont think this is a good recommandition.
> > The user should use the latest release, especially when he cares about
> > security
> 
> The oldabi branch is dedicated for, well, old ABI. Only oldabi and 0.5-0.7
> branches have old API/ABI. Now 0.6 and oldabi are not maintained, so what's
> left is 0.5 and 0.7.

unless someone volunteers to maintain 0.5/0.7 they should not be
called maintained, being in better shape and having a dedicated
maintainer are seperate things

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130712/4cfe8488/attachment.asc>