[FFmpeg-devel] [PATCH]Avoid an assertion failure in ff_init_vlc_sparse

[Derek Buitenhuis]

On 7/12/2013 8:25 PM, Carl Eugen Hoyos wrote:
>>> -        ff_init_vlc_sparse(&ccitt_vlc[i], 9, CCITT_SYMS,
>>> +        ret = ff_init_vlc_sparse(&ccitt_vlc[i], 9, CCITT_SYMS,
>>>                             ccitt_codes_lens[i], 1, 1,
>>>                             ccitt_codes_bits[i], 1, 1,
>>>                             ccitt_syms, 2, 2,
>>>                             INIT_VLC_USE_NEW_STATIC);
>>> +        if (ret < 0)
>>> +            return ret;
>>>      }
>>
>> Please properly re-indent things like these after, 
>> in a separate commit. e.g.:
> 
> Of course not, please be a little more careful 
> where you review.

What? Try as I might, I cannot ascertain how this response
is at all related to what I wrote.

I'll try to reword:

After you commit this, please fix the indentation in a
commit which will follow it.

e.g.

>         ret = ff_init_vlc_sparse(&ccitt_vlc[i], 9, CCITT_SYMS,
>                            ccitt_codes_lens[i], 1, 1,
>                            ccitt_codes_bits[i], 1, 1,
>                            ccitt_syms, 2, 2,
>                            INIT_VLC_USE_NEW_STATIC);

turns into:

>         ret = ff_init_vlc_sparse(&ccitt_vlc[i], 9, CCITT_SYMS,
>                                  ccitt_codes_lens[i], 1, 1,
>                                  ccitt_codes_bits[i], 1, 1,
>                                  ccitt_syms, 2, 2,
>                                  INIT_VLC_USE_NEW_STATIC);

- Derek