[FFmpeg-devel] Hardware CSC conversion segfault
Reimar Döffinger
Reimar.Doeffinger at gmx.de
Sat Jul 13 09:37:10 CEST 2013
On 13.07.2013, at 02:03, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> On 7/12/2013 7:58 PM, Reimar Döffinger wrote:
>> While you're certainly right in the general case (and since memcpy is used anyway in ths case there is no need to add complexity or assumptions), if making use of DR1 an application is free to provide a continuous buffer to the decoder.
>
> You're semi-mistaken for the deprecated API:
>
> http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/avcodec.h;h=f0ccfee940ae50979132134154fb4380e4bcb05e;hb=HEAD#l1979
>
> It will simply crash on many codecs (e.g. MPEG-based ones) if
> these ruels are not followed.
>
> As for the new API, uou are entirely mistaken:
>
> http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/avcodec.h;h=f0ccfee940ae50979132134154fb4380e4bcb05e;hb=HEAD#l2102
None of these say that get_buffer is not allowed to return continuous memory (i.e. malloc each plane separately - which would be an idiotic requirement) so I have no idea what you are talking about.
More information about the ffmpeg-devel
mailing list