[FFmpeg-devel] [WIP] libsox wrapper

[Paul B Mahol]

On 7/21/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> On date Friday 2013-04-05 18:07:35 +0200, Stefano Sabatini encoded:
>> On date Sunday 2013-03-31 18:22:13 +0200, Stefano Sabatini encoded:
>> > On date Thursday 2013-03-21 21:15:07 +0100, Stefano Sabatini encoded:
>> > [...]
>> > Updated, this time with a correct subject line, and hopefully working
>> > drain.
>> >
>> > Try it with:
>> > ffplay -f lavfi "flite=text=hey, sox=echo 0.8 0.7 1000 0.5 2000 0.3"
>> >
>> > Still missing:
>> > - proper configuration of effects
>> > - proper multi-channel support
>> > - thread-safe init
>> > --
>> > FFmpeg = Fanciful Fierce Miracolous Ponderous Esoteric Gangster
>>
>> > From 519a5ad62b9dfa44c164a686261a8c6f141775bf Mon Sep 17 00:00:00 2001
>> > From: Stefano Sabatini <stefasab at gmail.com>
>> > Date: Mon, 22 Aug 2011 14:37:42 +0200
>> > Subject: [PATCH] lavfi: add libsox wrapper
>> >
>> > Still incomplete.
>> >
>> > Based on a patch by Mina Nagy Zaki <mnzaki at gmail.com>.
>> > ---
>> >  configure                |    4 +
>> >  doc/filters.texi         |   37 ++++
>> >  libavfilter/Makefile     |    1 +
>> >  libavfilter/af_sox.c     |  428
>> > ++++++++++++++++++++++++++++++++++++++++++++++
>> >  libavfilter/allfilters.c |    1 +
>> >  5 files changed, 471 insertions(+)
>> >  create mode 100644 libavfilter/af_sox.c
>>
>> Updated WIP, not yet working properly with multichannel support, for
>> example:
>> ffplay -f lavfi "anullsrc=r=22100:cl=quad,sox=synth sin %-12 sin %-9 sin
>> %-5 sin %-2"
>> ffplay -f lavfi aevalsrc="-0.4:0.4" -af "sox=earwax"
>>
>> still have problems, and I still have various crashes with various
>> effects.
>>
>> As for what regards thread init, I wonder if we need to use a mutex or
>> atomic.h should be enough.
>>
>> Finally, regarding configuration, I'm assuming all the filters to
>> accepts whatever format, and that this is the same for input and
>> output. This works for most filters, but not for a few (e.g. mixer,
>> rate, which sets the output depending on the input - and which are
>> difficult to integrate in our query_formats() mechanism).
>
>
> Updated WIP, with a few fixes, in particular I fixed noiseprof, while
> noisered still seems to have problems:
>
> For example;
> ffmpeg -i test.ogg -af "sox=noisered test.noiseprof,ashowinfo" -f null -
>
> crashes here.

Remove echo example, as there is better native implementation.


> --
> FFmpeg = Friendly Faithless Maxi Pitiless Ermetic Gladiator
>