[FFmpeg-devel] [PATCH]Support muxing more qcelp samples in mov

[Carl Eugen Hoyos]

Paul B Mahol <onemda <at> gmail.com> writes:

> On 6/9/13, Carl Eugen Hoyos <cehoyos <at> ag.or.at> wrote:
> > Paul B Mahol <onemda <at> gmail.com> writes:
> >
> >> > Attached patch allows muxing of qcelp in mov and
> >> > playback with QuickTime.
> >>
> >> This is wrong, as it does not work for files that
> >> already have first byte that describe rate.
> >
> > Could you point me to a sample?
> 
> Actually, patch is plain wrong, as its increases 
> size of packets.

Really?

Could you please switch from the guessing / flaming 
mode to the review mode?
FFmpeg currently silently fails for remuxing a 
mostly obsolete codec, the patch fixes it. If you 
can fix the problem in a "better" way, I would be 
glad, if you cannot, please post a useful review.

Carl Eugen