[FFmpeg-devel] [PATCH] libavfromat/flvenc.c: Preserve the 'amf0' data stream written by Adobe Flash Media Servers while doing a data stream copy

[Benedict Endemann]

Am 07.03.2013 19:47, schrieb Carl Eugen Hoyos:
> Benedict Endemann <bendemann <at> make.tv> writes:
>
>> -        avio_w8(pb, AMF_DATA_TYPE_STRING);
>> -        put_amf_string(pb, "onTextData");
>> -        avio_w8(pb, AMF_DATA_TYPE_MIXEDARRAY);
>> +        if (enc->codec_id == AV_CODEC_ID_TEXT) {
>> +            avio_w8(pb, AMF_DATA_TYPE_STRING);
>> +            put_amf_string(pb, "onTextData");
>> +            avio_w8(pb, AMF_DATA_TYPE_MIXEDARRAY);
>> +            avio_wb32(pb, 2);
> ...
>
> Please do not mix functional with cosmetic changes,
> ie don't re-indent so many lines but leave them
> untouched. That makes reviewing easier.
> You may send a second patch to do the indentation
> change.
>
> Thank you, Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Dear Carl,

sorry it's the first patch I commited ever. Also my explanations of the 
patch and what it's good for, weren't deliverd as I wanted them to.
Do you want me to send in a new "clean" patch?

Best regards, Benedict Endemann