[FFmpeg-devel] [PATCH] ffprobe: Use a better user vissible name for AVFrame.pkt_dts

[Michael Niedermayer]

On Tue, Mar 19, 2013 at 01:39:55AM +0100, Stefano Sabatini wrote:
> On date Tuesday 2013-03-19 01:25:53 +0100, Michael Niedermayer encoded:
> > Might fix Ticket2375
> > 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  ffprobe.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/ffprobe.c b/ffprobe.c
> > index ef9bef4..6f0d4c0 100644
> > --- a/ffprobe.c
> > +++ b/ffprobe.c
> > @@ -1470,8 +1470,8 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream,
> >      print_int("key_frame",              frame->key_frame);
> >      print_ts  ("pkt_pts",               frame->pkt_pts);
> >      print_time("pkt_pts_time",          frame->pkt_pts, &stream->time_base);
> > -    print_ts  ("pkt_dts",               frame->pkt_dts);
> > -    print_time("pkt_dts_time",          frame->pkt_dts, &stream->time_base);
> > +    print_ts  ("dts_based_pts",         frame->pkt_dts);
> > +    print_time("dts_based_pts_time",    frame->pkt_dts, &stream->time_base);
> >      print_duration_ts  ("pkt_duration",      av_frame_get_pkt_duration(frame));
> >      print_duration_time("pkt_duration_time", av_frame_get_pkt_duration(frame), &stream->time_base);
> >      if (av_frame_get_pkt_pos (frame) != -1) print_fmt    ("pkt_pos", "%"PRId64, av_frame_get_pkt_pos(frame));
> 
> This breaks scripts. Also if we want to fix the name we should do it
> at the library level (at the next bump).

changing it at the library level would implicate breaking
compatibility with libav unless they change it too

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130319/f4a178ee/attachment.asc>