[FFmpeg-devel] [PATCH] doc/filters: add more curves examples

[Clément Bœsch]

On Mon, Mar 25, 2013 at 01:51:19PM -0800, Lou Logan wrote:
[...]
> > + at item preset
> > +Select one of the available color preset. This option can not be used in
> 
> Select one of the available color presets.

selected.

> or
> Select an available color preset.
> 

> > +addition to the @option{r}, @option{g}, @option{b} parameters.
> > +Available presets are:
> > + at table @samp
> > + at item color_negative
> > + at item cross_process
> > + at item darker
> > + at item increase_contrast
> > + at item lighter
> > + at item linear_contrast
> > + at item medium_contrast
> > + at item negative
> > + at item vintage
> > + at end table
> > +Default is unset.
> >  @end table
> >  
> >  To avoid some filtergraph syntax conflicts, each key points list need to be
> > @@ -2368,6 +2384,12 @@ Here we obtain the following coordinates for each components:
> >  @item blue
> >  @code{(0;0.22) (0.49;0.44) (1;0.80)}
> >  @end table
> > +
> > + at item
> > +The previous example can also be achieved with the associated pre-defined preset:
> 
> I don't think "pre-defined" is needed here.
> 

I replaced this with "built-in", hopefully that's better.

[...]
> > +    },{
> > +        "vintage",
> > +        "0/0.11 .42/.51 1/0.95",
> 
> Nit: 0.42/0.51 for consistency (or maybe remove the 0 from others if you
> prefer).
> 

Right, good point; it is as is in the documentation to show the different
possible syntaxes, but it makes no sense in the code. Changed.

> > +        "0.50/0.48",
> > +        "0/0.22 .49/.44 1/0.8",
> 
> Same as above.
> 
> These are just nits. Rest looks good to me, and thanks.
> 

Pushed.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130325/9b825f38/attachment.asc>