[FFmpeg-devel] [PATCH 2/2] cmdutils: support filters in the help topic system.

[Clément Bœsch]

On Sun, Mar 31, 2013 at 06:30:03PM +0200, Stefano Sabatini wrote:
[...]
> > +        return;
> > +    }
> > +    printf("Filter %s\n", filter->name);
> > +    if (filter->description)
> > +        printf("  %s\n", filter->description);
> > +    if (filter->priv_class)
> > +        show_help_children(filter->priv_class, AV_OPT_FLAG_FILTERING_PARAM);
> > +    else
> > +        printf("No AVOption available\n");
> 
> To use "AVOption" doesn't seem like a great idea (or we should start
> to fill user-documentatio with silly API jargon), but keep it again
> for consistency.
> 

I don't like it either, feel free to change.

> > +}
> > +
> >  int show_help(void *optctx, const char *opt, const char *arg)
> >  {
> >      char *topic, *par;
> > @@ -1626,6 +1648,8 @@ int show_help(void *optctx, const char *opt, const char *arg)
> >          show_help_demuxer(par);
> >      } else if (!strcmp(topic, "muxer")) {
> >          show_help_muxer(par);
> > +    } else if (!strcmp(topic, "filter")) {
> > +        show_help_filter(par);
> >      } else {
> >          show_help_default(topic, par);
> >      }
> 
> Should be probably advertised in the documentation.
> 

I would have add it to the documentation if the other ones were documented
:)

> LGTM, thanks.

Applied

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130331/0c5993ac/attachment.asc>