[FFmpeg-devel] [PATCH] Remove extensions from MPEG-PS muxers.
Michael Niedermayer
michaelni at gmx.at
Sun Nov 17 16:18:27 CET 2013
On Sun, Nov 17, 2013 at 01:25:32PM +0100, Reimar Döffinger wrote:
> When the file-name is .mpg, most users will not want a
> "MPEG-1 Systems" that almost all programs will fail to play (at least
> as soon as e.g. AC3 is muxed into it).
> It is also likely that a user encoding to a file ending in .vob
> is trying to encode in a DVD-compatible format.
> Either way, since two formats have the same extension, it would
> be "random" what the user gets, which certainly is not a good
> thing either.
>
> Related to trac issue #1720.
>
> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> ---
> libavformat/mpegenc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c
> index 0a9d69b..3c6cef2 100644
> --- a/libavformat/mpegenc.c
> +++ b/libavformat/mpegenc.c
> @@ -1173,7 +1173,6 @@ AVOutputFormat ff_mpeg1system_muxer = {
> .name = "mpeg",
> .long_name = NULL_IF_CONFIG_SMALL("MPEG-1 Systems / MPEG program stream"),
> .mime_type = "video/mpeg",
> - .extensions = "mpg,mpeg",
> .priv_data_size = sizeof(MpegMuxContext),
> .audio_codec = AV_CODEC_ID_MP2,
> .video_codec = AV_CODEC_ID_MPEG1VIDEO,
> @@ -1204,7 +1203,6 @@ AVOutputFormat ff_mpeg2vob_muxer = {
> .name = "vob",
> .long_name = NULL_IF_CONFIG_SMALL("MPEG-2 PS (VOB)"),
> .mime_type = "video/mpeg",
> - .extensions = "vob",
> .priv_data_size = sizeof(MpegMuxContext),
> .audio_codec = AV_CODEC_ID_MP2,
> .video_codec = AV_CODEC_ID_MPEG2VIDEO,
breaks fate and any script that encodes mpeg ps, dvds, .vob, .mpg
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131117/6a620884/attachment.asc>
More information about the ffmpeg-devel
mailing list