[FFmpeg-devel] [PATCH 2/2] configure: Add --enable-concise-version option.

[Michael Niedermayer]

On Tue, Nov 19, 2013 at 07:45:40PM -0500, Stephen Hutchinson wrote:
> On Tue, Nov 19, 2013 at 5:23 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> > Michael Niedermayer <michaelni <at> gmx.at> writes:
> >
> >> > > +  --enable-concise-version omit 'configuration:'
> >> > > from regular invocation
> >>
> >> iam not completely sure this is a good idea
> >
> > +1
> >
> >> its quite important that bug reports contain this information
> >
> > It is.
> >
> > Carl Eugen
> 
> The information being there on regular invocation to make bug reports
> easier is why this is set up purely as an opt-in.  The user has to
> actively not want to see it and tell configure they don't want it.
> Otherwise, you get both configuration reports and using -buildconf
> will show the configuration twice - once as part of the regular
> invocation, and then the one-per-line formatted output of -buildconf
> itself.
> 
> In the event the user does choose to disable configuration:, the
> regular invocation has an additional notice that the configuration can
> be viewed with -buildconf (the output of which can be copied into the
> bug report, like I did with ticket #3017; maybe there could be a
> mandatory field added to the reporting form that makes sure the
> configuration is always posted?  Is that possible with how trac is set
> up?).
> 

> > Michael Niedermayer <michaelni <at> gmx.at> writes:
> >
> > please see config.h and the code that creates it
> 
> So it should be
> enabled concise_version && add_cflags -DCONCISE_CONF
> instead?
> 
> I'm not sure what I should be looking at in config.h.

> Having it as a
> discrete #define that shows up in the list of defines in config.h?

yes, but it seems there is no consensus on the feature as such
so maybe wait with modifying the patch until/if everyone agrees
on how/if this should be done


> Using a different name (prefixed with HAVE_ or CONFIG_)?
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131120/7b523962/attachment.asc>