[FFmpeg-devel] [PATCH 2/2] ffmpeg: add max_error_rate to allow tuning the point decoding errors are considered a failure of the whole transcoding.

Derek Buitenhuis derek.buitenhuis at gmail.com
Tue Oct 1 18:34:16 CEST 2013


On Tue, Oct 1, 2013 at 5:28 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> -    if (2*decode_error_stat[0] < decode_error_stat[1])
> +    if (decode_error_stat[1] && (decode_error_stat[0] + decode_error_stat[1]) * max_error_rate <= decode_error_stat[1])
>          exit_program(69);

Shouldn't this be changed to 1, since after this patch, we consider it
an error (as per the user's settings)?

> @@ -2709,6 +2710,8 @@ const OptionDef options[] = {
>          "extract an attachment into a file", "filename" },
>      { "debug_ts",       OPT_BOOL | OPT_EXPERT,                       { &debug_ts },
>          "print timestamp debugging info" },
> +    { "max_error_rate",  HAS_ARG | OPT_FLOAT,                        { &max_error_rate },
> +        "maximum error rate", "rate between 0.0 and 1.1" },

What does this range represent? Should be added to the message.

- Derek


More information about the ffmpeg-devel mailing list