[FFmpeg-devel] [PATCH] build: make sure probed tools don't wait for stdin input.

Michael Niedermayer michaelni at gmx.at
Mon Oct 7 02:24:48 CEST 2013


On Sun, Oct 06, 2013 at 03:51:02PM -0300, James Almer wrote:
> On 06/10/13 7:45 AM, Michael Niedermayer wrote:
> > On Sat, Oct 05, 2013 at 09:06:27PM -0300, James Almer wrote:
> >> On 05/10/13 6:44 PM, Michael Niedermayer wrote:
> >>> On Fri, Feb 15, 2013 at 12:05:59AM +0100, Clément Bœsch wrote:
> >>>> On Wed, Jan 09, 2013 at 12:15:46AM +0100, Clément Bœsch wrote:
> >>>>> a758c5e added probing for various tools, such as as. Unfortunately, GNU
> >>>>> as is reading stdin with -v, and thus configure is stalled with
> >>>>> configure arguments such as --as=as.
> >>>>>
> >>>>> The --version calls are unchanged because it is supposed to -v + exit.
> >>>>>
> >>>>> Fixes Ticket #1898.
> >>>>
> >>>> Ping
> >>>
> >>> probably ok
> >>
> >> As i said back in February, the output of GNU as doesn't start with "gcc", 
> >> so the line
> >>
> >>> elif $_cc -v 2>&1 < /dev/null | grep -qi ^gcc; then
> >>
> >> needs to check for both "GNU" and "gcc".
> >> Something like grep -qi '^g\(cc\|nu\)' should do it.
> > 
> > yes but is this related to fixing the regresion that configure
> > waits infinitly on stdin? (which is what this patch is doing)
> > 
> > thanks
> 
> No, it fixes a bug introduced by fixing the hang on stdin.
> Since GNU as will not hang up anymore, the grep check will be done but fail 
> as it only checks for '^gcc'.

why dont you send patch(es) or pull req that fixes all this ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131007/bd9dfc32/attachment.asc>


More information about the ffmpeg-devel mailing list