[FFmpeg-devel] [PATCH 4/4] lavd/pulse: move common code to separate file

Stefano Sabatini stefasab at gmail.com
Mon Oct 7 12:00:29 CEST 2013


On date Friday 2013-10-04 18:16:22 +0200, Lukasz M encoded:
> On 4 October 2013 15:12, Stefano Sabatini <stefasab at gmail.com> wrote:
> 
> > On date Friday 2013-10-04 14:29:07 +0200, Lukasz Marek encoded:
> > > Signed-off-by: Lukasz Marek <lukasz.m.luki at gmail.com>
> > > ---
> > >  libavdevice/Makefile             |    6 ++++--
> > >  libavdevice/pulse_audio_common.c |   42
> > ++++++++++++++++++++++++++++++++++++++
> > >  libavdevice/pulse_audio_common.h |   29 ++++++++++++++++++++++++++
> > >  libavdevice/pulse_audio_dec.c    |   19 +----------------
> > >  libavdevice/pulse_audio_enc.c    |   19 +----------------
> >
> > pulse_audio.{h,c} is another option, and simpler (but less consistent
> > with other files).
> >
> 
> I have no opinion about that, I can change that.
> Attached patch fixes int -> enum AVCodecID pointed indirectly in other
> thread.

LGTM (but I'm no lavd maintainer).
-- 
FFmpeg = Fierce & Frightening Mean Puristic EnGraver


More information about the ffmpeg-devel mailing list