[FFmpeg-devel] [PATCH 2/4] lavd/pulse_audio_dec: add audio_device option

[Lukasz M]

On 11 October 2013 10:34, Paul B Mahol <onemda at gmail.com> wrote:

> On 10/10/13, Lukasz Marek <lukasz.m.luki at gmail.com> wrote:
> > Device can be selected by passing AVOption as well.
> >
> > Signed-off-by: Lukasz Marek <lukasz.m.luki at gmail.com>
> > ---
> >  doc/indevs.texi               |   11 +++++------
> >  libavdevice/pulse_audio_dec.c |   10 ++++++++--
> >  2 files changed, 13 insertions(+), 8 deletions(-)
> >
> > diff --git a/doc/indevs.texi b/doc/indevs.texi
> > index 6bcb237..b7981c6 100644
> > --- a/doc/indevs.texi
> > +++ b/doc/indevs.texi
> > @@ -489,12 +489,6 @@ PulseAudio input device.
> >
> >  To enable this output device you need to configure FFmpeg with
> > @code{--enable-libpulse}.
> >
> > -The filename to provide to the input device is a source device or the
> > -string "default"
> > -
> > -To list the PulseAudio source devices and their properties you can
> invoke
> > -the command @command{pactl list sources}.
> > -
> >  @subsection Options
> >  @table @option
> >  @item server
> > @@ -508,6 +502,11 @@ by default it is the @code{LIBAVFORMAT_IDENT}
> string.
> >  Specify the stream name PulseAudio will use when showing active streams,
> >  by default it is "record".
> >
> > + at item audio_device
> > +Specify the device to use. The specified input name is used as default.
> > +String "default" can be used to specify default device.
> > +List of input devices can be obtained with command @command{pactl list
> > sources}.
> > +
>
> This is breaking backward compatibility.
>

How it breaks backward compatibility? When new param is not provided then
it behaves exactly like before. it is not critical functionality, but
posibility to
select device is quite important and doing it by input name may lead to
problem
when other stuff will also use input name for its own purposes.



> Seriously I do not like such changes, next thing on such list are
> useless cosmetics changes.


I guess you point to my other 2 commits.
Making descriptions of paramas in dec and dec and doc entries more
consistent for enc and dec of the same module is not quite pointless.