[FFmpeg-devel] [PATCH 1/4] lavd/pulse_audio_enc: rename device param into audio_device

[Lukasz M]

On 11 October 2013 13:22, Stefano Sabatini <stefasab at gmail.com> wrote:

> On date Friday 2013-10-11 00:39:36 +0200, Lukasz Marek encoded:
> > device may refer for both audio and video device.
> > audio_device is clear.
>
> OTOH given that this is an audio device this is probably redundant.
>

Yes, but I have in mind a case when options are provided by command line
(e.g. for ffmpeg)
There is no control where option is passed. This make it easier to
distinguish.


> This is also technically an API break, need a micro bump.
>

I'm aware of that, but the original code is merged few days ago.
I doubt it will cause any problem. I can bump micro.