[FFmpeg-devel] [PATCH 1/2] avdevice/pulse_audio_enc: fix error check

Stefano Sabatini stefasab at gmail.com
Sat Oct 19 00:01:02 CEST 2013


On date Friday 2013-10-18 23:41:19 +0200, Lukasz Marek encoded:
> Error check should be done by checking negative value, not non-zero.
> 
> Signed-off-by: Lukasz Marek <lukasz.m.luki at gmail.com>
> ---
>  libavdevice/pulse_audio_enc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavdevice/pulse_audio_enc.c b/libavdevice/pulse_audio_enc.c
> index 25caa65..0a3aa1a 100644
> --- a/libavdevice/pulse_audio_enc.c
> +++ b/libavdevice/pulse_audio_enc.c
> @@ -105,7 +105,7 @@ static int pulse_write_packet(AVFormatContext *h, AVPacket *pkt)
>      if (s->stream_index != pkt->stream_index)
>          return 0;
>  
> -    if ((error = pa_simple_write(s->pa, buf, size, &error))) {
> +    if (pa_simple_write(s->pa, buf, size, &error) < 0) {
>          av_log(s, AV_LOG_ERROR, "pa_simple_write failed: %s\n", pa_strerror(error));
>          return AVERROR(EIO);
>      }

Applied, thanks.
-- 
FFmpeg = Friendly Funny Most Problematic Exploitable Game


More information about the ffmpeg-devel mailing list