[FFmpeg-devel] iSight camera support

[Lukasz M]

On 30 October 2013 11:39, Lukasz M <lukasz.m.luki at gmail.com> wrote:

> On 30 October 2013 03:53, Vadim Kalinsky <vadim at kalinsky.ru> wrote:
>
>>
>> On 2013-10-29, at 7:26 PM, Lukasz M <lukasz.m.luki at gmail.com> wrote:
>>
>> Thanks for your comments, Lukasz
>>
>> > On 28 October 2013 21:21, Vadim Kalinsky <vadim at kalinsky.ru> wrote:
>> >
>> > I'm not Mac developer, but iOS and also don't know QTKit, but have few
>> > remarsk after quick look
>> >
>> > In general you should fix formatting and styles. It is messy.
>>
>> I tried to keep Objective-C "camel case" style in Objective-C code.
>>
>> > It would be easier to review when you squash patches. Last one adds new
>> > line only. :)
>>
>>
>> I created the patch from github pull request, seems like this feature
>> doesn't work well there.
>>
>> New patch attached.
>>
>
> Also, I think Autorelease pool should be moved to CaptureContext.
> call [pool drain] at the end of isight_read_header and isight_read_packet
> and [pool release] in destroy_context.
> Otherwise autoreleased objects during capture will leak if no pool from
> "outside" is provided.
>

Ignore this comment, it is wrong.