[FFmpeg-devel] [PATCH]Force gif aspect ratio multiplication to 64bit

[Michael Niedermayer]

On Sat, Apr 05, 2014 at 01:07:28AM +0200, Carl Eugen Hoyos wrote:
> On Thursday 03 April 2014 12:36:41 pm Michael Niedermayer wrote:
> > > -        aspect = sar.num * 64 / sar.den - 15;
> > >
> > > +        aspect = sar.num * 64ULL / sar.den - 15;
> > >          if (aspect < 0 || aspect > 255)
> >
> > thats not sufficient, aspect is just an int and this might not fit
> > in it also the <0 check needs int64 not uint64
> 
> Is attached better?

yes, LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140405/a68f633f/attachment.asc>