[FFmpeg-devel] [PATCH 2/4] proresenc_kostya: report buffer overflow

Michael Niedermayer michaelni at gmx.at
Tue Aug 12 02:15:50 CEST 2014

On Mon, Aug 11, 2014 at 10:06:08PM +0000, Christophe Gisquet wrote:
> If the allocated size, despite best efforts, is too small, exit
> with the appropriate error.
> ---
>  libavcodec/proresenc_kostya.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)

This is kind of an internal error, we should ideally allocate the
buffer large enough, or reallocate as needed, but the case tested
for here should never happen if everything else works correctly

but its alot safer to do this check than to not do it
so applied


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140812/0abde56a/attachment.asc>

More information about the ffmpeg-devel mailing list