[FFmpeg-devel] [PATCH] gifdec: use truncated width for image manipulation

Christophe Gisquet christophe.gisquet at gmail.com
Mon Aug 18 09:42:08 CEST 2014


2014-08-17 23:53 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
>> > i think these need a check for top >= s->screen_height and
>> > left >= s->screen_width
> 0x00000000007319ea in gif_fill_rect (picture=0x1a96a60, color=16777215, l=0, t=65535, w=192, h=-65367) at libavcodec/gifdec.c:108

Sorry for missing the obvious, indeed in those cases pw/height would
end negative...

So I have added the checks you propose and decided to shuffle them
with the others.

Updated patch attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gifdec-use-truncated-width-for-image-manipulation.patch
Type: text/x-patch
Size: 3825 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140818/eb43ab63/attachment.bin>

More information about the ffmpeg-devel mailing list