[FFmpeg-devel] [PATCH] lavf/wavdec: add sanity check for AVCodecContext.channels

[James Almer]

On 18/08/14 4:42 AM, Michael Niedermayer wrote:
> On Mon, Aug 18, 2014 at 03:14:01AM -0300, James Almer wrote:
>> Fixes ticket #3862.
>> As a side effect, this also fixes aac_latm in wav.
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
> 
> applied
> 
> 
>> ---
>> Maybe a check for channels <= 0 should be also added to ff_get_wav_header()
>> right after the sample_rate one?
> 
> sounds reasonable, would need to be tested though

It seems that according to the wav spec, "channels" can only have values from 1 to 
UINT16_MAX, so a wav header where it's 0 means it's most assuredly broken.

Fate passes after adding a check to ff_get_wav_header(). Is there some other kind 
of test that could be done?

> 
> thanks
> 
> [...]
> 
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>