[FFmpeg-devel] [PATCH] lavf/tiff: add support for YUV deflate

Michael Niedermayer michaelni at gmx.at
Tue Aug 19 21:22:56 CEST 2014

On Tue, Aug 19, 2014 at 01:39:33PM -0300, James Almer wrote:
> On 19/08/14 7:07 AM, Michael Niedermayer wrote:
> > is photometric guranteed to match the pix_fmt ?
> >
> > iam asking as i dont see that being ensured by the code but i might
> > be missing something
> > if they could mismatch, id assume it might crash
> TIFF_PHOTOMETRIC_YCBCR seems to simply be a flag to signal yuv data. If it's set, 
> init_image() chooses the pix_fmt by looking at some other values in the file.
> I copied the exact same check used in other compression algorithms (lzw, packbits, 
> even raw) to know if it's yuv or rgb, and process it if the former. So if there 
> hasn't been any kind of mismatch in those, it shouldn't in this one either.

true, but there is a mismatch in them
ive fixed the one i saw, dunno if there are more


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140819/059677b6/attachment.asc>

More information about the ffmpeg-devel mailing list