[FFmpeg-devel] [PATCH 3/3] avfilter/vf_lenscorrection: get rid of floats i init code

Michael Niedermayer michaelni at gmx.at
Wed Aug 20 14:33:18 CEST 2014

On Wed, Aug 20, 2014 at 02:23:10PM +0200, Daniel Oberhoff wrote:
> So we prefer int64_t above float32?

well, its not exactly making me happy either but its just 2 32x32->64
operations per pixel which  shouldnt be that bad when we need to do
16 multiplications for bicubic per sample
also at the expense of a bit more space they could be precalculated
as they dont change between frames

> I assumed we stick with 32bits for calculations. Did you test this with very large resolutions?

just tried:
./ffplay -f lavfi -i testsrc=s=16385x8192  -vf lenscorrection=0.3:0.2:0.2:0.9,scale=640x48
which seems working

> I so congratulation :). I am glad I could push you to finish what I failed to do :).
> As I would still like to have interpolation, I assume I shall refactor the interpolation out of perspective and rotation instead, right?

yes, please do


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140820/1da41f08/attachment.asc>

More information about the ffmpeg-devel mailing list