[FFmpeg-devel] [PATCH] x86/hecv_res_add: add ff_hevc_transform_add{8, 16, 32}_8_avx

Christophe Gisquet christophe.gisquet at gmail.com
Wed Aug 20 21:11:20 CEST 2014


2014-08-20 17:36 GMT+02:00 James Almer <jamrial at gmail.com>:
>> Does avx => ARCH_X86_64 (didn't know) ? Otherwise the reg count seems
>> fine, meaning the condition is unneeded.
> No, AVX does not imply x86_64. The reg count for these is currently 12 xmm regs,
> meaning x86_64 only.
> I'll send a patch to get them down to 8 or so later.

I somehow completely misread the reg count. Indeed.

>> So couldn't this one be instantiated to use xmm regs? (mmx may be a
>> burden eg need for emms and need to rewrite it).
> Aren't you thinking about the 10bit functions? All three AVX I'm adding here are 8bit
> and using xmm. There are no 8bit AVX2 functions currently.

You're right. At this point, I think I accidentally read pierre's
original or something, where I saw "INIT_YMM avx2".

Please disregard my previous mail, patch ok, and sorry.


More information about the ffmpeg-devel mailing list