[FFmpeg-devel] [PATCH 1/3] avfilter/showwaves: add "center" mode.
Clément Bœsch
u at pkh.me
Wed Aug 20 22:26:14 CEST 2014
On Wed, Aug 20, 2014 at 01:02:21PM +0200, Stefano Sabatini wrote:
> On date Tuesday 2014-08-19 14:47:02 +0200, Clément Bœsch encoded:
> > From: Clément Bœsch <clement at stupeflix.com>
> >
> > ---
> > doc/filters.texi | 3 +++
> > libavfilter/avf_showwaves.c | 24 +++++++++++++++++++-----
> > 2 files changed, 22 insertions(+), 5 deletions(-)
> >
> > diff --git a/doc/filters.texi b/doc/filters.texi
> > index 0ca1d6f..828f2b4 100644
> > --- a/doc/filters.texi
> > +++ b/doc/filters.texi
> > @@ -10813,6 +10813,9 @@ Draw a vertical line for each sample.
> >
> > @item p2p
> > Draw a point for each sample and a line between them.
> > +
> > + at item center
> > +Draw a centered vertical line for each sample.
> > @end table
> >
> > Default value is @code{point}.
> > diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c
> > index e025663..e4911cc 100644
> > --- a/libavfilter/avf_showwaves.c
> > +++ b/libavfilter/avf_showwaves.c
> > @@ -36,6 +36,7 @@ enum ShowWavesMode {
> > MODE_POINT,
> > MODE_LINE,
> > MODE_P2P,
>
> > + MODE_CENTER,
>
> Nit: what about CENTERED_LINE, then you can use cl or cline as abbreviation.
>
Sure whatever.
[...]
> LGTM otherwise, thanks.
Applied, thanks
--
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140820/79cfc815/attachment.asc>
More information about the ffmpeg-devel
mailing list