[FFmpeg-devel] [PATCH] imc: reject files with unfathomable sampling rates

Michael Niedermayer michaelni at gmx.at
Thu Aug 21 14:25:27 CEST 2014

On Thu, Aug 21, 2014 at 12:32:52PM +0200, Christophe Gisquet wrote:
> Hi,
> ticket #3868 is about a fuzzed file containing a weird sampling rate.
> "richardpl" (?) suggestion is perfectly fine in my opinion.
> I didn't put one, but don't hesitate to put the proper "-by".


> -- 
> Christophe

>  imc.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> efcf55e549ecbbd7513fdd6a33304a20b51f883d  0001-imc-reject-files-with-unfathomable-sampling-rates.patch
> From 412a719ac4ab830ddc35b3d7e99fab2ccb543279 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Thu, 21 Aug 2014 12:21:07 +0200
> Subject: [PATCH] imc: reject files with unfathomable sampling rates
> With huge sampling rates, the table derivation method does not converge fast
> enough. While fixing it using e.g. Newton-Rhapson-like methods (the curve is
> nicely convex) is possible, it is much simpler to reject these cases.

i would suggest simple bisection instead of more complex methods
if someone wants to improve this

either way, i aggree this solution is fully adequate



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140821/0de269a9/attachment.asc>

More information about the ffmpeg-devel mailing list