[FFmpeg-devel] [PATCH] mov: better check dref atome validity

Christophe Gisquet christophe.gisquet at gmail.com
Thu Aug 21 15:08:55 CEST 2014


2014-08-21 14:55 GMT+02:00 Derek Buitenhuis <derek.buitenhuis at gmail.com>:
> On 8/21/2014 12:09 PM, Christophe Gisquet wrote:
>> I'm not sure it is the best fix, but I don't think this could happen
>> in any valid file, nor it would help to swallow the error.
> Perhaps off-topic, but the source drop from Elemental seems to include
> completely rewritten dref code -- is it worth looking at?

Actually, the more I think about this patch, the more I want to drop
it: I'm not a mov expert.

Basically, it makes sense, but the caller tries to handle overreads by
just moving to the expected end of the atom. Not a very sane practive
unless ones knows that code to be prone to such issues and thinks it
can be recovered.

As for the new dref code, I'm not an expert, so no opinion.


More information about the ffmpeg-devel mailing list