[FFmpeg-devel] [PATCH]Do not show an unreadable error code if mov header parsing fails

Carl Eugen Hoyos cehoyos at ag.or.at
Sat Aug 23 14:02:49 CEST 2014


I don't think showing "-1094995529" or similar makes much sense.
The calling application can still decide to show the error 
string (as ffmpeg does).

Please comment, Carl Eugen
-------------- next part --------------
diff --git a/libavformat/mov.c b/libavformat/mov.c
index b3eb287..ae48c02 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -3562,7 +3562,7 @@ static int mov_read_header(AVFormatContext *s)
     if (mov->moov_retry)
         avio_seek(pb, 0, SEEK_SET);
     if ((err = mov_read_default(mov, pb, atom)) < 0) {
-        av_log(s, AV_LOG_ERROR, "error reading header: %d\n", err);
+        av_log(s, AV_LOG_ERROR, "error reading header\n");
         return err;

More information about the ffmpeg-devel mailing list