[FFmpeg-devel] [PATCH] tests: switch to a test image that is under public domain
Michael Niedermayer
michaelni at gmx.at
Tue Aug 26 13:52:19 CEST 2014
On Tue, Aug 26, 2014 at 11:16:24AM +0200, Clément Bœsch wrote:
> On Tue, Aug 26, 2014 at 01:42:17AM +0200, Michael Niedermayer wrote:
> > From: Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>
> >
> > ---
> > LICENSE.md | 1 +
> > tests/Makefile | 2 +-
> > tests/flower.pnm | Bin 0 -> 196623 bytes
> > tests/lena.pnm | 109 ----------------------------
> > tests/ref/fate/force_key_frames | 8 +-
> > tests/ref/fate/sub2video | 100 ++++++++++++-------------
> > tests/ref/seek/vsynth2-asv1 | 40 +++++-----
> > tests/ref/seek/vsynth2-asv2 | 40 +++++-----
> > tests/ref/seek/vsynth2-ffv1 | 40 +++++-----
> > tests/ref/seek/vsynth2-flashsv | 40 +++++-----
> > tests/ref/seek/vsynth2-flv | 40 +++++-----
> > tests/ref/seek/vsynth2-h261 | 40 +++++-----
> > tests/ref/seek/vsynth2-h263 | 40 +++++-----
> > tests/ref/seek/vsynth2-h263p | 40 +++++-----
> > tests/ref/seek/vsynth2-huffyuv | 40 +++++-----
> > tests/ref/seek/vsynth2-jpegls | 40 +++++-----
> > tests/ref/seek/vsynth2-ljpeg | 40 +++++-----
> > tests/ref/seek/vsynth2-mjpeg | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg1 | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg1b | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg2-422 | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg2-idct-int | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg2-ilace | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg2-ivlc-qprd | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg2-thread | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg2-thread-ivlc | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg4 | 48 ++++++------
> > tests/ref/seek/vsynth2-mpeg4-adap | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg4-adv | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg4-error | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg4-nr | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg4-nsse | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg4-qpel | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg4-qprd | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg4-rc | 40 +++++-----
> > tests/ref/seek/vsynth2-mpeg4-thread | 40 +++++-----
> > tests/ref/seek/vsynth2-msmpeg4 | 40 +++++-----
> > tests/ref/seek/vsynth2-msmpeg4v2 | 40 +++++-----
> > tests/ref/seek/vsynth2-roqvideo | 2 +-
> > tests/ref/seek/vsynth2-rv10 | 55 +++++++-------
> > tests/ref/seek/vsynth2-rv20 | 54 +++++++-------
> > tests/ref/seek/vsynth2-snow | 40 +++++-----
> > tests/ref/seek/vsynth2-snow-ll | 40 +++++-----
> > tests/ref/seek/vsynth2-svq1 | 48 ++++++------
> > tests/ref/seek/vsynth2-wmv1 | 40 +++++-----
> > tests/ref/seek/vsynth2-wmv2 | 40 +++++-----
> > tests/ref/vsynth/vsynth2-amv | 8 +-
> > tests/ref/vsynth/vsynth2-asv1 | 8 +-
> > tests/ref/vsynth/vsynth2-asv2 | 8 +-
> > tests/ref/vsynth/vsynth2-avui | 4 +-
> > tests/ref/vsynth/vsynth2-cljr | 6 +-
> > tests/ref/vsynth/vsynth2-dnxhd-1080i | 6 +-
> > tests/ref/vsynth/vsynth2-dnxhd-720p | 6 +-
> > tests/ref/vsynth/vsynth2-dnxhd-720p-10bit | 6 +-
> > tests/ref/vsynth/vsynth2-dnxhd-720p-rd | 6 +-
> > tests/ref/vsynth/vsynth2-dv | 6 +-
> > tests/ref/vsynth/vsynth2-dv-411 | 6 +-
> > tests/ref/vsynth/vsynth2-dv-50 | 6 +-
> > tests/ref/vsynth/vsynth2-ffv1 | 6 +-
> > tests/ref/vsynth/vsynth2-ffv1.0 | 6 +-
> > tests/ref/vsynth/vsynth2-ffvhuff | 6 +-
> > tests/ref/vsynth/vsynth2-ffvhuff420p12 | 8 +-
> > tests/ref/vsynth/vsynth2-ffvhuff422p10left | 8 +-
> > tests/ref/vsynth/vsynth2-ffvhuff444 | 8 +-
> > tests/ref/vsynth/vsynth2-ffvhuff444p16 | 8 +-
> > tests/ref/vsynth/vsynth2-flashsv | 8 +-
> > tests/ref/vsynth/vsynth2-flashsv2 | 8 +-
> > tests/ref/vsynth/vsynth2-flv | 8 +-
> > tests/ref/vsynth/vsynth2-h261 | 8 +-
> > tests/ref/vsynth/vsynth2-h261-trellis | 8 +-
> > tests/ref/vsynth/vsynth2-h263 | 8 +-
> > tests/ref/vsynth/vsynth2-h263-obmc | 8 +-
> > tests/ref/vsynth/vsynth2-h263p | 8 +-
> > tests/ref/vsynth/vsynth2-huffyuv | 6 +-
> > tests/ref/vsynth/vsynth2-huffyuvbgr24 | 8 +-
> > tests/ref/vsynth/vsynth2-huffyuvbgra | 8 +-
> > tests/ref/vsynth/vsynth2-jpeg2000 | 8 +-
> > tests/ref/vsynth/vsynth2-jpeg2000-97 | 8 +-
> > tests/ref/vsynth/vsynth2-jpegls | 8 +-
> > tests/ref/vsynth/vsynth2-ljpeg | 6 +-
> > tests/ref/vsynth/vsynth2-mjpeg | 8 +-
> > tests/ref/vsynth/vsynth2-mjpeg-422 | 8 +-
> > tests/ref/vsynth/vsynth2-mjpeg-444 | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg1 | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg1b | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg2 | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg2-422 | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg2-idct-int | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg2-ilace | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg2-ivlc-qprd | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg2-thread | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg2-thread-ivlc | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg4 | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg4-adap | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg4-adv | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg4-error | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg4-nr | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg4-nsse | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg4-qpel | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg4-qprd | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg4-rc | 8 +-
> > tests/ref/vsynth/vsynth2-mpeg4-thread | 8 +-
> > tests/ref/vsynth/vsynth2-mpng | 8 +-
> > tests/ref/vsynth/vsynth2-msmpeg4 | 8 +-
> > tests/ref/vsynth/vsynth2-msmpeg4v2 | 8 +-
> > tests/ref/vsynth/vsynth2-msvideo1 | 8 +-
> > tests/ref/vsynth/vsynth2-prores | 8 +-
> > tests/ref/vsynth/vsynth2-prores_ks | 8 +-
> > tests/ref/vsynth/vsynth2-qtrle | 8 +-
> > tests/ref/vsynth/vsynth2-qtrlegray | 8 +-
> > tests/ref/vsynth/vsynth2-r210 | 6 +-
> > tests/ref/vsynth/vsynth2-rgb | 6 +-
> > tests/ref/vsynth/vsynth2-roqvideo | 8 +-
> > tests/ref/vsynth/vsynth2-rv10 | 8 +-
> > tests/ref/vsynth/vsynth2-rv20 | 8 +-
> > tests/ref/vsynth/vsynth2-snow | 8 +-
> > tests/ref/vsynth/vsynth2-snow-hpel | 8 +-
> > tests/ref/vsynth/vsynth2-snow-ll | 6 +-
> > tests/ref/vsynth/vsynth2-svq1 | 8 +-
> > tests/ref/vsynth/vsynth2-v210 | 6 +-
> > tests/ref/vsynth/vsynth2-v308 | 6 +-
> > tests/ref/vsynth/vsynth2-v408 | 4 +-
> > tests/ref/vsynth/vsynth2-wmv1 | 8 +-
> > tests/ref/vsynth/vsynth2-wmv2 | 8 +-
> > tests/ref/vsynth/vsynth2-y41p | 6 +-
> > tests/ref/vsynth/vsynth2-yuv | 4 +-
> > tests/ref/vsynth/vsynth2-yuv4 | 4 +-
> > tests/ref/vsynth/vsynth2-zlib | 8 +-
> > 128 files changed, 1161 insertions(+), 1268 deletions(-)
> > create mode 100644 tests/flower.pnm
> > delete mode 100644 tests/lena.pnm
> >
>
> Can you add this chunk:
>
> diff --git a/doc/writing_filters.txt b/doc/writing_filters.txt
> index c7923e8..6f4952c 100644
> --- a/doc/writing_filters.txt
> +++ b/doc/writing_filters.txt
> @@ -25,9 +25,9 @@ for others using the `./ffmpeg -v 0 -filters|grep ' V->V '` command.
> pattern of the other filters.
> - ./configure ...
> - make -j<whatever> ffmpeg
> - - ./ffmpeg -i tests/lena.pnm -vf foobar foobar.png
> + - ./ffmpeg -i tests/flower.pnm -vf foobar foobar.png
>
> -If everything went right, you should get a foobar.png with Lena edge-detected.
> +If everything went right, you should get a foobar.png with flowers edge-detected.
>
> That's it, your new playground is ready.
>
>
> [...]
>
> I'm fine with the patch, even though Lena has a special meaning in video
> processing...
yep, i wonder if this is the best solution after sleepng over it.
the lena image is well known, also people know how girls look,
people will recognize artiacts easily in it.
Noone would easily notice if a flower has a different color tone or
some spots. So it may be better to actually try to keep using lena
In that light ive posted a naive patch that just downloads lena.pnm
if its missing, a 3rd alternative to that would be to move it to the
fate suite as andreas initially suggested.
Ive not done that one though as theres a significant number of test
cases on mailing lists and the bug tracker that refer to lena.pnm
they all would break without it and worse having no image in the
source, we could not just refer to a image from the source tree
anymore for such purposes
comments welcome
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140826/c1083ba4/attachment.asc>
More information about the ffmpeg-devel
mailing list