[FFmpeg-devel] [PATCH] lavc/libwebpenc: use WebPMemoryWriterClear()

[James Zern]

On Wed, Aug 27, 2014 at 10:49 AM, James Almer <jamrial at gmail.com> wrote:
> On 27/08/14 2:37 PM, Pascal Massimino wrote:
>> Hi,
>>
>>
>> On Wed, Aug 27, 2014 at 10:06 AM, Michael Niedermayer <michaelni at gmx.at>
>> wrote:
>>
>>> On Wed, Aug 27, 2014 at 12:57:47AM -0300, James Almer wrote:
>>>> WebPMemoryWriterClear() must be used instead of free() when libwebp ABI
>>> version is > 0x0202.
>>>
>>
>> It's rather 0x0203. The patch that introduced WebPMemoryWriterClear() is
>> here: https://gerrit.chromium.org/gerrit/#/c/69362/5/src/webp/encode.h
>
> webp/encode.h from libwebp 0.4.1 (current stable version) shows this
> http://git.chromium.org/gitweb/?p=webm/libwebp.git;a=blob;f=src/webp/encode.h;h=dd600568fb70b5332ea0a022ae449d35c0d5e5f2;hb=refs/heads/0.4.1#l234
>
> Can't deny the fact the commit that introduced this bumped the api from 0x0203 to 0x0204,
> so I'll assume this is a mistake in the 0.4.1 branch.

It is, I mistakenly clumped the values for this and another bump
together. This condition will still hold between releases, but 0x0203
is the correct value to use here.