[FFmpeg-devel] [PATCH] tests: Download lena.pnm if its missing from the source tree

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Thu Aug 28 13:28:18 CEST 2014


On 28.08.2014 04:36, Michael Niedermayer wrote:
> On Wed, Aug 27, 2014 at 05:21:18PM -0800, Lou Logan wrote:
>> On Tue, 26 Aug 2014 13:41:42 +0200, Michael Niedermayer wrote:
>>
>>> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
>>> ---
>>>   tests/Makefile |    5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tests/Makefile b/tests/Makefile
>>> index 07557f9..2f095df 100644
>>> --- a/tests/Makefile
>>> +++ b/tests/Makefile
>>> @@ -24,13 +24,16 @@ $(VREF): tests/videogen$(HOSTEXESUF) | tests/vsynth1
>>>   $(AREF): tests/audiogen$(HOSTEXESUF) | tests/data
>>>   	$(M)./$< $@
>>>
>>> +$(SRC_PATH)/tests/lena.pnm:
>>> +	wget -O $@  http://samples.ffmpeg.org/image-samples/lena.pnm
>>
>> I feel like I'm missing something, but what about this suggestion from
>> Nicolas?
>>
>>>> ffmpeg -f data -i http://samples.ffmpeg.org/image-samples/lena.pnm -c copy -f data -map 0 -y lena.pnm
>>
>> From:
>> <https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2014-August/161881.html>
>
> possible
>
> but would this make andreas / debian happy ?

No.

> IIRC theres no net access from the build deamons and andreas wants
> to run the subset of tests that dont need fate samples or at least
> thats how i understood it ...
> andreas, please correct me if iam wrong

That's correct.
But I'm fine with moving lena.pnm to the FATE samples, which are 
downloaded with 'make fate-rsync'.
Attached patch removes tests/lena.pnm and adapts the tests, assuming 
lena.pnm would be added to the top-level of the SAMPLES directory.

Best regards,
Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Remove-non-free-tests-lena.pnm.patch
Type: text/x-diff
Size: 286907 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140828/0e51e3ee/attachment.bin>


More information about the ffmpeg-devel mailing list