[FFmpeg-devel] [PATCH] avfilter/vf_tinterlace: Favor using standard timebases for the output

[Kieran Kunhya]

Sent from my mobile device
On 1 Dec 2014 21:55, "Michael Niedermayer" <michaelni at gmx.at> wrote:
>
> On Mon, Dec 01, 2014 at 08:54:16PM +0000, Vittorio Giovara wrote:
> > On Mon, Dec 1, 2014 at 8:04 PM, Michael Niedermayer <michaelni at gmx.at>
wrote:
> > > Inspired by discussion with kierank
> > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> >
> > Missing a 'Reported by' tag I believe.
>
> added
>
>
> >
> > > ---
> > >  libavfilter/tinterlace.h    |    1 +
> > >  libavfilter/vf_tinterlace.c |   24 ++++++++++++++++++++++--
> > >  2 files changed, 23 insertions(+), 2 deletions(-)
> >
> > This leaves vf_interlace broken, and having working timestamps was
> > among the main reasons of having a spin-off filter. Whatever the fix
> > ends up being, please apply it there too.
>
> I dont think the patch will apply cleanly there, also
> If correct timestamps are the main reason for vf_interlace, then why
> was tinterlace not fixed instead of taking a subset of its features
> and creating a new filter out of that ?

Because vf_tinterlace is a completely undocumented filter where some of the
options have nothing to do with interlacing.

It should have been left in Mplayer.

I would strongly advise all users of these filters generate their own
timestamps.