[FFmpeg-devel] [PATCH] Incorrect aspect ratio in MPEG2 essence

Michael Niedermayer michaelni at gmx.at
Thu Dec 4 17:27:01 CET 2014


On Thu, Dec 04, 2014 at 01:11:08PM +0100, Erik Johansson wrote:
> Hi,
> 
> Setting setting sample_aspect_ratio in AVContext does not produce the
> expected aspect index value in the MPEG2 sequence header.
> 
> Problem seems to be around line 263 in mpeg12enc.c. Setting the
> sample_aspect_ratio to 16/9 leads the current error minimization
> routine to determine that
> 
> error -= (1LL<<32)*(221/100)*(1080/1920)
> 
> is smaller than
> 
> error -= (1LL<<32)*(16/9)*(1080/1920)
> 
> thus picking aspect index value 4 rather than 3.
> 
> Proposed fix in attached patch.

how can this bug be reproduced ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141204/b3c14ac4/attachment.asc>


More information about the ffmpeg-devel mailing list