[FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

[arwa arif]

On Fri, Dec 19, 2014 at 12:15 PM, Timothy Gu <timothygu99 at gmail.com> wrote:
>
> On Dec 18, 2014 10:31 PM, "arwa arif" <arwaarif1994 at gmail.com> wrote:
> >
> > On Fri, Dec 19, 2014 at 10:40 AM, Michael Niedermayer <michaelni at gmx.at>
> > wrote:
> > >
> > > it segfaults without -cpuflags 0 here
> > > ./ffplay   -i matrixbench_mpeg2.mpg -vf fspp
> > >
> > >
> > I tried this command on my system, and it is not giving segfault on my
> > system.
> >
> >
> > > #0  0x00000000004d0e7a in store_slice_mmx (dst=0x7fffc4612b60 "",
> > > src=0x7ffff7e07e50, dst_stride=-1440, src_stride=32, width=720,
> height=8,
> > > log2_scale=1) at libavfilter/x86/vf_fspp.c:49
> > >
> >
> > Here, the value of dst_stride is -1440, which shouldn't be negative. So,
> > when I looked into mplayer code, store_slice_mmx has input arguments of
> > type long. Maybe that is the problem, so I have updated the patch
> replacing
> > int by int32_t.
>
> Actually ptrdiff_t is a better choice here.
>
> Timothy
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


Okay, thanks.
Updated the patch.
Can someone please check if its still giving segfault or not? On my system,
its working fine.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavfi-port-mp-fspp-to-a-native-libavfilter-filter.patch
Type: text/x-patch
Size: 91512 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141219/58cdb78b/attachment.bin>