[FFmpeg-devel] [PATCH] Parse cookies more correctly

[Scott Moak]

Yes it is related to the "Expires" fix. A cookie with the "Expires" doesn't
get parsed correctly. For example:

A cookie like this

lu=Rg3vHJZnehYLjVg7qi3bZjzg; Expires=Tue, 15-Jan-2013 21:47:38 GMT; Path=/;
Domain=.example.com;

will get tokened:

   - lu=Rg3vHJZnehYLjVg7qi3bZjzg
   - Expires=Tue,
   - 15-Jan-2013
   - 21:47:38
   - GMT

such that each of those is considered its own param in the while loop.


On Sat, Feb 8, 2014 at 12:41 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Scott Moak <scott.moak <at> mybrainoncode.com> writes:
>
> > Cookies with an Expires directive do not get parsed (and ignored)
> > correctly, so we need to fix that.
>
> > -        while ((param = av_strtok(cookie, "; ", &next_param))) {
> > +        while ((param = av_strtok(cookie, ";", &next_param))) {
> >              cookie = NULL;
> > +            /* skip leading spaces */
> > +            param += strspn(param, " ");
>
> Is this related to the "Expires" fix?
>
> If it is an additional fix, please consider sending
> two patches.
>
> Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>