[FFmpeg-devel] [PATCH] x86: convert DNxHDenc inline asm to yasm

[Ronald S. Bultje]

Hi,

On Wed, Mar 26, 2014 at 2:36 AM, James Almer <jamrial at gmail.com> wrote:

> On 26/03/14 12:21 AM, Timothy Gu wrote:
> > Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
> > ---
> > First asm patch...
> > ---
> >  libavcodec/x86/Makefile        |  3 +-
> >  libavcodec/x86/dnxhdenc.asm    | 50 +++++++++++++++++++++++++++++++
> >  libavcodec/x86/dnxhdenc.c      | 67
> ------------------------------------------
> >  libavcodec/x86/dnxhdenc_init.c | 39 ++++++++++++++++++++++++
> >  4 files changed, 91 insertions(+), 68 deletions(-)
> >  create mode 100644 libavcodec/x86/dnxhdenc.asm
> >  delete mode 100644 libavcodec/x86/dnxhdenc.c
> >  create mode 100644 libavcodec/x86/dnxhdenc_init.c
>
> I think it makes more sense moving this to DSPContext (And therefore to
> dsputilenc.asm).
> DNXHDEncContext already uses several DSPContext functions, and this
> get_pixels_8x4_sym
> function is generic enough (And very similar to other get_pixel ones) that
> it should
> probably be there as well.


DSPContext must die. I'm fine with renaming it into something like
MpegEncDSPContext or something along those lines, but then it shouldn't
contain functions for dnxhd. I'm also fine with renaming it into
DnxhdEncDSPContext, but then it shouldn't contain functions for mpeg.

The funny thing is that audio decoders use DSPContext also. How much code
do you think video and audio decoders share, dsp-wise?

Ronald