[FFmpeg-devel] [PATCH] Add a gamma flag to exr loader to avoid banding

Carl Eugen Hoyos cehoyos at ag.or.at
Thu May 1 22:19:55 CEST 2014


Gonzalo Garramuno <ggarra13 <at> gmail.com> writes:

> I attached a new patch that does not mess the indentation.

Please remove this hunk:

-            // 16-bit
-            for (x = 0; x < xdelta; x++) {
-                *ptr_x++ = exr_halflt2uint(bytestream_get_le16(&r));
-                *ptr_x++ = exr_halflt2uint(bytestream_get_le16(&g));
-                *ptr_x++ = exr_halflt2uint(bytestream_get_le16(&b));
-                if (channel_buffer[3])
-                    *ptr_x++ = exr_halflt2uint(bytestream_get_le16(&a));
-            }
+             /* 16-bit */
+             for (x = 0; x < xdelta; x++) {
+                 *ptr_x++ = s->gamma_table[bytestream_get_le16(&r)];
+                 *ptr_x++ = s->gamma_table[bytestream_get_le16(&g)];
+                 *ptr_x++ = s->gamma_table[bytestream_get_le16(&b)];
+                 if (channel_buffer[3])
+                      *ptr_x++ = exr_halflt2uint(bytestream_get_le16(&a));
+             }

And patcheck still reports trailing whitespace: 
Our repository refuses such changes.

Carl Eugen



More information about the ffmpeg-devel mailing list