[FFmpeg-devel] [PATCH] AVFoundation: Add -pixel_format option

[sfan5]

On 11.05.2014 17:44 Carl Eugen Hoyos wrote:
> sfan5 <sfan5 <at> live.de> writes:
>
>> +    { AV_PIX_FMT_RGB0, kCVPixelFormatType_24RGB },
> This should be AV_PIX_FMT_RGB24.
> (I believe you didn't test, this fails with an
> appropriate error message here.)
> Same for BGR0.
I already fixed this, see my last mail.
>
>> +    { AV_PIX_FMT_BGRA, kCVPixelFormatType_32BGRA },
> This should be AV_PIX_FMT_BGR0: The camera cannot
> record an alpha channel, the fourth channel is (or at
> least can be) 0, so it should be ignored.
> Same for the other 32 bit rgb formats.
Isn't AVFoundation a generic API for video sources? (not only cameras)
There might be other devices that can record RGBA.
>
> Imo, you don't have to add the pixel formats to the
> documentation. If you believe it makes sense, please
> remove gray (it's currently listed twice) once and
> update rgbx as above.
Fixed!
>
> Right now, if I specify a pixel format that does not
> work (like gray) FFmpeg prints many error messages
> but does not quit. Can you reproduce this?
> The expected behaviour imo is to quit if a pixel
> format that does not work is requested.
I can reproduce this, but I am not sure which approach one would to take 
to fix this.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-AVFoundation-Add-pixel_format-option.patch
Type: text/x-patch
Size: 6076 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140511/0f9578ad/attachment.bin>