[FFmpeg-devel] [PATCH] undef main when using SDL with MSVC toolchain

[John Peebles]

Attached is a new patch with the check for MINGW32 dropped.


On Fri, May 16, 2014 at 10:44 PM, Timothy Gu <timothygu99 at gmail.com> wrote:

> On May 16, 2014 7:34 PM, "John Peebles" <johnpeeb at gmail.com> wrote:
> >
> > On windows, the SDL library headers redefine main as SDL_main, which
> would
> > break the build off ffplay since there is no entry point when linking. To
> > fix this, cmdutils.h includes the lines
> >
> > #ifdef __MINGW32__
> > #undef main /* We don't want SDL to override our main() */
> > #endif
> >
> > However, MINGW32 is not defined when doing a build with the MSVC
> toolchain.
> > This causes a linker error when trying to build ffplay using the MSVC
> > toolchain. The included patch adds an additional check for the MSVC
> > compiler and undefines main if we are using it, fixing the linker error.
>
> I'm pretty sure MinGW defines _WIN32 too so you can drop the check for it.
>
> Timothy
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cmdutils-undef-main-when-using-SDL-with-VC-compiler-.patch
Type: application/octet-stream
Size: 678 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140516/dd1d5f3c/attachment.obj>