[FFmpeg-devel] [PATCH] avformat/mux: warning only on streams with pts < dts

[Aman Gupta]

Nicolas George <george <at> nsup.org> writes:

>
> Le primidi 21 floréal, an CCXXII, ffmpeg <at> tmm1.net a écrit :
> > From: Aman Gupta <ffmpeg <at> tmm1.net>
> >
> > Remove the "av_interleaved_write_frame(): Invalid argument" error when
> > remuxing a stream with non-monotonous pts timestamps.
> >
> > Fixes ticket #3621
>
> AFAIK, there are a lot of formats where producing a file with PTS < DTS is
> forbidden. I do not think that silently producing invalid files can be
> called "fixing" a ticket.

Sorry for the laconic description. I tried to make a case for the
warning in my ticket, which I should have repeated in the patch. My
goal was to ignore the error only in the remuxing case, where it
seemed reasonable that a broken input file would create a broken
output file in a different container.

That said, I'm happy to work on a better solution if you can provide
some suggestions for better approaches. ffmpeg already takes care to
rewrite timestamps when non-monotonous DTS is detected.. perhaps we
should do the same for PTS?

  Aman