[FFmpeg-devel] [PATCH] Message queue API

[Clément Bœsch]

On Sat, May 10, 2014 at 07:28:09PM +0200, Nicolas George wrote:
> Le quintidi 15 floréal, an CCXXII, Clément Bœsch a écrit :
> > I'm not sure an empty struct is valid in C, you may need to add a dummy
> > field or something to avoid chocking with random compilers.
> 
> I did check with gcc, and it did not complain even in pedantic mode, but
> after a more thorough glance to the standard it seems indeed necessary.
> 
> > Those should probably be size_t, but it's not important.
> 
> The fifo API uses ints.
> 
> > BTW, I know this is a pain to change now, but the number of element is
> > often (always?) put before the element size.
> 
> Changed.
> 
> > It's static so please drop the av_ prefix
> > ditto
> 
> I prefer to keep the identical name with the _unlocked versions.
> 
> Updated patches attached, for the order of arguments.
> 
> Regards,
> 
> -- 
>   Nicolas George

> From 3a0b7a170c0c722e8018975b18019c1d2d3d735a Mon Sep 17 00:00:00 2001
> From: Nicolas George <george at nsup.org>
> Date: Thu, 20 Feb 2014 14:14:34 +0100
> Subject: [PATCH 2/3] lavu: add thread message API.
> 
> TODO minor bump and APIchanges entry.
> 
> Signed-off-by: Nicolas George <george at nsup.org>
> ---
>  libavutil/Makefile        |   2 +
>  libavutil/threadmessage.c | 184 ++++++++++++++++++++++++++++++++++++++++++++++
>  libavutil/threadmessage.h |  91 +++++++++++++++++++++++
>  3 files changed, 277 insertions(+)
>  create mode 100644 libavutil/threadmessage.c
>  create mode 100644 libavutil/threadmessage.h
> 

ping, LGTM, etc :)

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140525/4761416e/attachment.asc>