[FFmpeg-devel] [PATCH 04/15] libavcodec/libavutil: Implementation of AAC_fixed_decoder (LC-module) [4/5]
Michael Niedermayer
michaelni at gmx.at
Fri Nov 14 13:19:17 CET 2014
On Fri, Nov 14, 2014 at 11:44:23AM +0000, Nedeljko Babic wrote:
> >On Fri, Nov 07, 2014 at 04:08:08PM +0100, Nedeljko Babic wrote:
> >> From: Djordje Pesut <djordje.pesut at imgtec.com>
> >>
> >> Add fixed point implementation
> >[...]
> >
> >> diff --git a/libavutil/fixed_dsp.h b/libavutil/fixed_dsp.h
> >> index ff6f365..3035d19 100644
> >> --- a/libavutil/fixed_dsp.h
> >> +++ b/libavutil/fixed_dsp.h
> >> @@ -54,6 +54,25 @@
> >> #include "libavcodec/mathops.h"
> >>
> >> typedef struct AVFixedDSPContext {
> >> + /* assume len is a multiple of 16, and arrays are 32-byte aligned */
> >> +
> >> + /**
> >> + * Calculate the product of two vectors of integers and store the result in
> >> + * a vector of integers.
> >
> >vector_fmul works with fixed point numbers or scales down integers
> >it doesnt just multiply them
> >
>
> This is fixed point multiplication ...
> Maybe it would be clearer if I put this in comment?
yes
>
> >
> >> + *
> >> + * @param dst output vector
> >> + * constraints: 32-byte aligned
> >> + * @param src0 first input vector
> >> + * constraints: 32-byte aligned
> >> + * @param src1 second input vector
> >> + * constraints: 32-byte aligned
> >> + * @param len number of elements in the input
> >> + * constraints: multiple of 16
> >> + */
> >> + void (*vector_fmul)(int *dst, const int *src0, const int *src1,
> >> + int len);
> >
> >this breaks ABI, new fields can only be added at the end
> >
>
> Should I order the fields in AVFixedDSPContext the be in the same order as fields
> in AVFloatDSPContext (for the fields that are supported in both structures), or
> sould I just add fields that are added with this patch to the end?
please add them to the end
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141114/7d63f91c/attachment.asc>
More information about the ffmpeg-devel
mailing list