[FFmpeg-devel] [PATCH] xface: Fix encoder crashes due to too small on-stack array.

[Michael Niedermayer]

On Sun, Nov 23, 2014 at 12:01:57PM +0100, Stefano Sabatini wrote:
> On date Sunday 2014-11-23 06:53:04 +0100, Reimar Döffinger encoded:
> > On Sat, Nov 22, 2014 at 11:14:45PM +0100, Reimar Döffinger wrote:
> > > Also add a FATE test.
> > > 
> > > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > > ---
> > >  libavcodec/xface.h             | 9 +++++----
> > >  libavcodec/xfaceenc.c          | 3 +++
> > >  libavformat/nut.c              | 1 +
> > 
> > I forgot this part:
> > 
> > >  const AVCodecTag ff_nut_video_tags[] = {
> > > +    { AV_CODEC_ID_XFACE,            MKTAG('X', 'F', 'A', 'C') },
> > 
> > Is that ok to just do?
> 
> I noticed that, probably a separate commit would be better indeed.
> 
> This change should be approved by Michael (not sure if this requires
> NUT specification updates).

ok, also please update nut4cc.txt

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141123/0b473caa/attachment.asc>