[FFmpeg-devel] [PATCH v3] ffprobe: Add bits_per_component to stream output

[Stefano Sabatini]

On date Friday 2014-09-05 13:40:17 +0200, Tobias Rapp encoded:
> On 05.09.2014 11:56, Stefano Sabatini wrote:
[...]
> >>>Does something such highly specialized really warrant its own API
> >>>function? There are several ways how to handle the case if the
> >>>component bit depths are not uniform, or even how the term "bit depth"
> >>>is to be interpreted, so IMO this should just be internal to ffprobe.
> >>
> >
> >>That would also be fine for me. Do you suggest to put it directly in
> >>ffprobe.c or cmdutils.c or some other file?
> >
> >Alternatively, we expose the pixdesc information through a specific
> >ffprobe option (-show_pixel_descriptions?) so it can be processed by
> >the caller.
> 
> You mean something like -pix_fmts with enhanced information in a
> more machine readable format?

Yes, I propose to use the same output formats supported by ffprobe,
through printers (JSON, XML, etc.).

> >The problem with the current approach is that it leads to
> >inconsistency, the bits-per-component information is not really
> >related to the stream but is computed starting from the pix_fmt
> >information, which is duplicated in other parts of the ffprobe
> >output.
> 
> That's true. I can also imagine that other parts of pixdesc
> information could be added later (nb_components, chroma
> sub-sampling, alpha/rgb flags) so this would mean a rather large
> amount of duplicated information.
> 
> >Having to process the output of ffprobe -show_pixel_descriptions may
> >require much work but would provide a more general solution (and it
> >would be useful for other purposes). Would that be acceptable to you?
> 
> If the output is somehow machine readable (e.g. format based on
> -print_format) I agree that your proposal should be preferred.
> 
> Thanks for the feedback. Will try to come up with a new patch within
> the next days.

If you don't, please open a ticket and I will look at it.
-- 
FFmpeg = Fancy & Fierce Mean Patchable Eretic Geek