[FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

[wm4]

On Wed, 8 Apr 2015 22:26:23 +0200
Gilles Chanteperdrix <gilles.chanteperdrix at xenomai.org> wrote:

> On Wed, Apr 08, 2015 at 10:08:25PM +0200, wm4 wrote:
> > On Wed, 08 Apr 2015 20:52:12 +0100
> > Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> > 
> > > On 4/8/2015 6:16 PM, Gilles Chanteperdrix wrote:
> > > > Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix at xenomai.org>
> > > > ---
> > > >  libavformat/Makefile     |   1 +
> > > >  libavformat/allformats.c |   1 +
> > > >  libavformat/youtubedl.c  | 221 +++++++++++++++++++++++++++++++++++++++++++++++
> > > >  3 files changed, 223 insertions(+)
> > > >  create mode 100644 libavformat/youtubedl.c
> > > 
> > > I must say this is incredibly dumb and has no place at all in libav*format*. This
> > > should be done in the layer above whatever avformat (and not even to mention the
> > > hilarity of running a cli script from a library).
> > > 
> > > I am registering my dissent here, in writing, so I can point to it in the future
> > > when asked (and I always get asked).
> > > 
> > > NOTE: I am sure people will respond and explain how avformat is totally the right
> > > place, just like it was the right place for a dir listing api, and an http server,
> > > and probably soon systemd. I am not going to respond, or otherwise engage in
> > > mailing list flamewars. This mail is read-only.
> > 
> > +1
> > 
> > As usual, people are trying to force things that don't belong into a
> > low level API, just because the low level API is the only API in ffmpeg.
> 
> For my defense again: the libquvi demuxer caused a segmentation
> fault, I posted here, you answered that the project was dead, so I looked
> for a replacement. I am not trying to force anything. I am ready to
> forget all about these patches.
> 

That's fine... I already disagreed with the original libquvi patch, but
of course that has nothing to do with your actions. Maintaining a
wrapper for a dead library when there's something better that _everyone_
can use easily seems like a waste, though. (But then FFmpeg tends to not
remove old broken stuff for some reason.)