[FFmpeg-devel] [PATCH] ffmpeg_vdpau: Ignore decoder's max supported level

[Philip Langdale]

On Sun, 16 Aug 2015 22:36:26 +0000 (UTC)
Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Philip Langdale <philipl <at> overt.org> writes:
> 
> > -    if (av_vdpau_bind_context(s, ctx->device,
> > ctx->get_proc_address, 0))
> > +    if (av_vdpau_bind_context(s, ctx->device,
> > ctx->get_proc_address, AV_HWACCEL_FLAG_IGNORE_LEVEL))
> 
> Shouldn't this be the default?
> How can a level ever be a reason to fail?

You can imagine this might be a real thing - if an h.264 decoder had a
bitrate limit it might work for 4.1 and not for 5.1 content. I don't
know if any hardware API except VDPAU reports a level limit - certainly
our VDPAU code is the only one that respects this flag, and it doesn't
seem like a good idea to check the level for VDPAU. It's a public API
change to reverse the default and the flag, blah blah, so I've not
attempted to do that here. I think pretty much every application sets
this flag for obvious reasons - ffmpeg.c is the exception.

--phil