[FFmpeg-devel] [PATCH 2/2] lavf/file: check for dirent.h support

[Mariusz Szczepańczyk]

On Thu, Jun 25, 2015 at 12:09 PM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> On Wed, Jun 24, 2015 at 03:25:18AM +0200, Mariusz Szczepańczyk wrote:
> > On Tue, Jun 23, 2015 at 8:34 PM, Michael Niedermayer <michaelni at gmx.at>
> > wrote:
> >
> > > On Mon, Jun 22, 2015 at 12:01:33AM +0200, Mariusz Szczepańczyk wrote:
> > > > ---
> > > >  configure          |  2 ++
> > > >  libavformat/file.c | 34 ++++++++++++++++++++++++++++++++++
> > > >  2 files changed, 36 insertions(+)
> > >
> > > this and the previous patch fails to build
> > >
> > > make distclean ; ./configure --disable-sdl && make -j12
> > >
> > > libavformat/file.c: In function ‘file_read_dir’:
> > > libavformat/file.c:302:10: error: ‘DT_FIFO’ undeclared (first use in
> this
> > > function)
> > > libavformat/file.c:302:10: note: each undeclared identifier is reported
> > > only once for each function it appears in
> > > libavformat/file.c:305:10: error: ‘DT_CHR’ undeclared (first use in
> this
> > > function)
> > > libavformat/file.c:308:10: error: ‘DT_DIR’ undeclared (first use in
> this
> > > function)
> > > libavformat/file.c:311:10: error: ‘DT_BLK’ undeclared (first use in
> this
> > > function)
> > > libavformat/file.c:314:10: error: ‘DT_REG’ undeclared (first use in
> this
> > > function)
> > > libavformat/file.c:317:10: error: ‘DT_LNK’ undeclared (first use in
> this
> > > function)
> > > libavformat/file.c:320:10: error: ‘DT_SOCK’ undeclared (first use in
> this
> > > function)
> > > libavformat/file.c:323:10: error: ‘DT_UNKNOWN’ undeclared (first use in
> > > this function)
> > > make: *** [libavformat/file.o] Error 1
> > > make: *** Waiting for unfinished jobs....
> > >
> > > sdl disable is needed to reproduce  as sdls pkgcnonfig adds
> > > GNU_SOURCE i suspect
> > >
> >
> > Added contraint on _GNU_SOURCE and now it compiles fine on my linux in
> both
> > cases (with or without sdl).
>
> The code probably should #ifdef DT_... like DT_FIFO
> also are both variants needed ?
> are there systems lacking some of the S_IS*() ? or is there some
> disadvantage in their use ? (i dont know, just asking ...)
>
> testing for _GNU_SOURCE is not correct, nothing gurantees that the
> compiler or headers know or react to _GNU_SOURCE
>

Yet another try.

Completely removed reliance on DT_* and added definitions for some S_* that
can be missing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lavf-file-check-for-dirent.h-support.patch
Type: text/x-patch
Size: 4760 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150821/656b4b06/attachment.bin>