[FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

[James Almer]

On 23/08/15 5:09 PM, Ganesh Ajjanagadde wrote:
> On Sun, Aug 23, 2015 at 3:42 PM, James Almer <jamrial at gmail.com> wrote:
>> On 23/08/15 4:10 PM, Ganesh Ajjanagadde wrote:
>>> I notice one use in entire codebase (line 515 of avformat/dump.c), so
>>> it should be ok in my view.
>>
>> Nevermind, missed this.
>>
>> Not sure how it works with msvc 2012 though, assuming the msdn link
>> documentation is right.
> 
> You might be onto something, note that this was introduce in June 2015,
> commit ID: df22e30172b09cda4d6f7d4f43508284be65848a.
> 
> Maybe build on such MSVC broke since then?
> That would perhaps explain why it was not caught yet,
> assuming we don't have many MSVC 2012 testers.

We have a msvc 2012 client and it compiles that file just fine without any
related warning.

http://fate.ffmpeg.org/log.cgi?time=20150822170001&log=compile&slot=x86_32-msvc11-windows-native