[FFmpeg-devel] [PATCH 1/4] avcodec: remove FF_API_LOWRES around max_lowres

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Sun Aug 23 23:40:32 CEST 2015


On 22.08.2015 20:36, wm4 wrote:
> On Sat, 22 Aug 2015 20:23:28 +0200
> Andreas Cadhalpun <andreas.cadhalpun at googlemail.com> wrote:
> 
>> On 22.08.2015 20:16, wm4 wrote:
>>> On Sat, 22 Aug 2015 19:56:53 +0200
>>> Andreas Cadhalpun <andreas.cadhalpun at googlemail.com> wrote:
>>>
>>>> This fixes building with FF_API_LOWRES disabled.
>>>>
>>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>>>> ---
>>>>  libavcodec/avcodec.h | 2 --
>>>>  1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>>>> index 41f373b..12a6b54 100644
>>>> --- a/libavcodec/avcodec.h
>>>> +++ b/libavcodec/avcodec.h
>>>> @@ -3493,9 +3493,7 @@ typedef struct AVCodec {
>>>>      const int *supported_samplerates;       ///< array of supported audio samplerates, or NULL if unknown, array is terminated by 0
>>>>      const enum AVSampleFormat *sample_fmts; ///< array of supported sample formats, or NULL if unknown, array is terminated by -1
>>>>      const uint64_t *channel_layouts;         ///< array of support channel layouts, or NULL if unknown. array is terminated by 0
>>>> -#if FF_API_LOWRES
>>>>      uint8_t max_lowres;                     ///< maximum value for lowres supported by the decoder, no direct access, use av_codec_get_max_lowres()
>>>> -#endif
>>>>      const AVClass *priv_class;              ///< AVClass for the private context
>>>>      const AVProfile *profiles;              ///< array of recognized profiles, or NULL if unknown, array is terminated by {FF_PROFILE_UNKNOWN}
>>>>  
>>>
>>> I thought LOWRES was undeprecated anyway?
>>
>> It more or less is.
>> After this patch the only change is that lowres gets moved down to the internal
>> section in AVCodecContext. API users should use accessor functions for it.
> 
> Makes sense then, patch ok.

Pushed.

Best regards,
Andreas



More information about the ffmpeg-devel mailing list